feat: token transfer operator == adition by Egbaiyelo · Pull Request #1320 · hiero-ledger/hiero-sdk-cpp

Egbaiyelo · 2026-04-04T17:01:26Z

Description:

Implementing the TokenTransfer== operator

Related issue(s):

Fixes #1298

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

github-actions · 2026-04-04T17:01:53Z

Hey @Egbaiyelo 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:

PR Checks

✅ DCO Sign-off -- All commits have valid sign-offs. Nice work!

✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded!

✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing!

✅ Issue Link -- Linked to #1298 (assigned to you).

🎉 All checks passed! Your PR is ready for review. Great job!

codacy-production · 2026-04-04T17:03:24Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity

Metric Results

Complexity 5

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

rwalworth

Thanks for the contribution @Egbaiyelo! There are a few things to address before this can be merged:

Issue link fix: The PR description has Fixes # 1298 (space after #) - GitHub won't auto-link that, which is why the bot flagged it. Please update it to Fixes #1298 (no space).

I left a few comments below on the code changes. Let me know if you have any questions!

src/sdk/main/include/TokenTransfer.h

src/sdk/main/src/TokenTransfer.cc

src/sdk/tests/unit/TokenTransferUnitTests.cc

Egbaiyelo · 2026-04-05T01:07:38Z

I genuinely cant run the tests for some reason? something about hproto-populate?

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

Egbaiyelo · 2026-04-05T03:05:02Z

@rwalworth So I am a bit confused with the test cases, i came back realising I might not have done the right thing, I think they cover everything now but I dont see the structure of what I did in the codebase

rwalworth

Thanks for the updates @Egbaiyelo — good progress on the SPDX header fix and adding the //----- separator! There are still a couple of things to address before this can merge, the most critical being that the operator== implementation in TokenTransfer.cc is a free function rather than a member function, which means it won't compile. I've left the details in the comments below.

src/sdk/main/src/TokenTransfer.cc

rwalworth · 2026-04-05T15:37:26Z

@rwalworth So I am a bit confused with the test cases, i came back realising I might not have done the right thing, I think they cover everything now but I dont see the structure of what I did in the codebase

The tests look good - they cover all three cases required by the issue:

Two default-constructed instances are equal ✓
Two identically-constructed instances are equal ✓
Instances differing in each field are not equal ✓

The structure (going straight from // Given to // Then without an explicit // When) is a bit different from some of the other tests in the file, but it's perfectly fine for equality assertions - the test name makes the intent clear.

One minor thing: in OperatorEqualsDiff, testTokenTransfer is constructed with the hardcoded value true for mIsApproval. Since getTestIsApproval() also returns true, they're equivalent - using getTestIsApproval() would be slightly more consistent with the rest of the test, but it's not a blocker.

The reason you can't run the tests right now is the compilation error in TokenTransfer.cc - the operator== is a free function that can't access the member variables. Once that's fixed (see the thread on that file), things should build and the tests should pass!

rwalworth · 2026-04-05T15:37:46Z

I genuinely cant run the tests for some reason? something about hproto-populate?

Can you share the full error message? An error mentioning "hproto-populate" sounds like a build system or dependency issue unrelated to your changes - possibly a missing proto generation step or a stale build cache.

src/sdk/tests/unit/TokenTransferUnitTests.cc

Egbaiyelo · 2026-04-05T19:15:53Z

ill rebuild it actually

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

rwalworth

Thanks for sticking with this @Egbaiyelo - the implementation and test coverage are looking good now! The operator== logic is correct, the //----- separator is there, the member function form is right, and the SPDX header is clean. Just one small doc comment fix needed in the header before this can merge.

src/sdk/main/include/TokenTransfer.h

src/sdk/tests/unit/TokenTransferUnitTests.cc

src/sdk/main/src/TokenTransfer.cc

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

rwalworth

LGTM - all the blocking issues have been resolved! Running the workflows now and will merge once they pass!

github-actions · 2026-04-08T18:33:23Z

👋 Hi @Egbaiyelo! Great work on your recent contribution! 🎉

Here are some issues you might want to explore next:

Happy coding! 🚀

feat: token transfer operator == adition

3a7c351

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

Egbaiyelo requested review from a team as code owners April 4, 2026 17:01

Egbaiyelo requested review from SimiHunjan and agadzhalov April 4, 2026 17:01

github-actions bot assigned Egbaiyelo Apr 4, 2026

github-actions bot added the status: needs revision A pull request that requires changes before merge label Apr 4, 2026

fix: test case for TokenTransfer ==operator

ac140dd

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

rwalworth requested changes Apr 5, 2026

View reviewed changes

src/sdk/main/include/TokenTransfer.h Outdated Show resolved Hide resolved

src/sdk/main/src/TokenTransfer.cc Outdated Show resolved Hide resolved

src/sdk/tests/unit/TokenTransferUnitTests.cc Outdated Show resolved Hide resolved

github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Apr 5, 2026

fix: tokentransfer blocking issues for == operator

b79455b

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

Egbaiyelo force-pushed the feat/tokentransfer== branch from 1d2345c to b79455b Compare April 5, 2026 01:19

fix: update tests

19ff63c

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

rwalworth requested changes Apr 5, 2026

View reviewed changes

src/sdk/main/src/TokenTransfer.cc Show resolved Hide resolved

src/sdk/main/src/TokenTransfer.cc Outdated Show resolved Hide resolved

rwalworth added status: needs revision A pull request that requires changes before merge and removed status: needs review The pull request is ready for maintainer review labels Apr 5, 2026

Egbaiyelo commented Apr 5, 2026

View reviewed changes

src/sdk/tests/unit/TokenTransferUnitTests.cc Outdated Show resolved Hide resolved

fix: clang format for tokentransfer == operator

9ec4ae0

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Apr 5, 2026

rwalworth requested changes Apr 5, 2026

View reviewed changes

src/sdk/main/include/TokenTransfer.h Show resolved Hide resolved

src/sdk/tests/unit/TokenTransferUnitTests.cc Outdated Show resolved Hide resolved

src/sdk/main/src/TokenTransfer.cc Show resolved Hide resolved

src/sdk/main/src/TokenTransfer.cc Outdated Show resolved Hide resolved

rwalworth removed the status: needs review The pull request is ready for maintainer review label Apr 5, 2026

rwalworth added the status: needs revision A pull request that requires changes before merge label Apr 5, 2026

fix: conflicts for TokenTransfer == operator

7188073

Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>

github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Apr 8, 2026

rwalworth approved these changes Apr 8, 2026

View reviewed changes

rwalworth merged commit 993d0e8 into hiero-ledger:main Apr 8, 2026
11 checks passed

rwalworth removed the status: needs review The pull request is ready for maintainer review label Apr 8, 2026

Conversation

Egbaiyelo commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checks

Uh oh!

codacy-production bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

rwalworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Egbaiyelo commented Apr 5, 2026

Uh oh!

Egbaiyelo commented Apr 5, 2026

Uh oh!

rwalworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rwalworth commented Apr 5, 2026

Uh oh!

rwalworth commented Apr 5, 2026

Uh oh!

Uh oh!

Egbaiyelo commented Apr 5, 2026

Uh oh!

rwalworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rwalworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Egbaiyelo commented Apr 4, 2026 •

edited

Loading

github-actions bot commented Apr 4, 2026 •

edited

Loading

codacy-production bot commented Apr 4, 2026 •

edited

Loading